Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve chapter4 exercise only using existing concepts #365

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

appetere
Copy link

The current solution for the exercise 2. in https://github.com/purescript-contrib/purescript-book/blob/master/text/chapter4.md#exercises uses various constructs that haven't been introduced in the text.

Proposed change uses only constructs that the book has already used in examples.

@milesfrain
Copy link
Member

Greatly appreciated!

Looks like we just need an import for null to fix the CI failure.

Pattern matching would make some of these solutions even more idiomatic, but we'd need to swap ch4 and ch5 as described in #340.

@appetere
Copy link
Author

Sorry, missed the null on copy and paste! Pushed now.

@milesfrain milesfrain merged commit 2672424 into purescript-contrib:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants