merge branch to main

push-protocol · May 10, 2024 · 92f84f5 · 92f84f5
2 parents f039900 + 17febb3
commit 92f84f5
Show file tree

Hide file tree

Showing 27 changed files with 2,125 additions and 398 deletions.
diff --git a/packages/restapi/src/lib/pushNotification/notification.ts b/packages/restapi/src/lib/pushNotification/notification.ts
@@ -14,6 +14,7 @@ import {
   getCAIPWithChainId,
   validateCAIP,
   getFallbackETHCAIPAddress,
+  pCAIP10ToWallet,
 } from '../helpers';
 
 import { PushNotificationBaseClass } from './pushNotificationBase';
@@ -50,11 +51,16 @@ export class Notification extends PushNotificationBaseClass {
       raw = false,
     } = options || {};
     try {
-      const account = options?.account
-        ? options.account
-        : this.account
-        ? getFallbackETHCAIPAddress(this.env!, this.account!)
-        : null;
+      let account: string | null;
+      if (options?.account) {
+        if (this.isValidPCaip(options.account)) {
+          account = pCAIP10ToWallet(options.account);
+        } else {
+          account = options.account;
+        }
+      } else if(this.account){
+        account = getFallbackETHCAIPAddress(this.env!, this.account!)
+      }
       // guest mode and valid address check
       this.checkUserAddressExists(account!);
       const nonCaipAccount = this.getAddressFromCaip(account!);
@@ -99,11 +105,16 @@ export class Notification extends PushNotificationBaseClass {
         channel = null,
         raw,
       } = options || {};
-      const account = options?.account
-        ? options.account
-        : this.account
-        ? getFallbackETHCAIPAddress(this.env!, this.account!)
-        : null;
+      let account: string | null;
+      if (options?.account) {
+        if (this.isValidPCaip(options.account)) {
+          account = pCAIP10ToWallet(options.account);
+        } else {
+          account = options.account;
+        }
+      } else if(this.account){
+        account = getFallbackETHCAIPAddress(this.env!, this.account!)
+      }
       this.checkUserAddressExists(account!);
       return await PUSH_USER.getSubscriptions({
         user: account!,

diff --git a/packages/restapi/src/lib/pushNotification/pushNotificationBase.ts b/packages/restapi/src/lib/pushNotification/pushNotificationBase.ts
@@ -33,6 +33,8 @@ import {
 import { axiosGet, axiosPost } from '../utils/axiosUtil';
 import { PushAPI } from '../pushapi/PushAPI';
 import { channel } from 'diagnostics_channel';
+import * as viem from 'viem';
+
 
 // ERROR CONSTANTS
 const ERROR_ACCOUNT_NEEDED = 'Account is required';
@@ -843,7 +845,7 @@ export class PushNotificationBaseClass {
         throw new Error('Signer is not provided');
       }
       const pushSigner = new Signer(this.signer);
-      let addAliasRes
+      let addAliasRes;
       if (!pushSigner.isViemSigner(this.signer)) {
         if (!this.signer.provider) {
           throw new Error('ethers provider is not provided');
@@ -875,12 +877,13 @@ export class PushNotificationBaseClass {
         throw new Error('Signer is not provided');
       }
       const pushSigner = new Signer(this.signer);
-      let verifyAliasRes
+      let verifyAliasRes;
       if (!pushSigner.isViemSigner(this.signer)) {
         if (!this.signer.provider) {
           throw new Error('ethers provider is not provided');
         }
-        const addAliasTrxPromise = contract!['verifyChannelAlias'](channelAddress);
+        const addAliasTrxPromise =
+          contract!['verifyChannelAlias'](channelAddress);
         const addAliasTrx = await addAliasTrxPromise;
         await this.signer?.provider?.waitForTransaction(addAliasTrx.hash);
         verifyAliasRes = addAliasTrx.hash;
@@ -926,4 +929,13 @@ export class PushNotificationBaseClass {
   protected getAddressFromCaip(caipAddress: string): string {
     return caipAddress?.split(':')[caipAddress?.split(':').length - 1];
   }
+
+  protected isValidPCaip(address: string): boolean {
+    const addressComponents = address.split(':');
+    return (
+      addressComponents.length == 2 &&
+      addressComponents[0] == 'eip155' &&
+      viem.isAddress(addressComponents[1])
+    );
+  }
 }
diff --git a/packages/restapi/tests/lib/notification/notification.test.ts b/packages/restapi/tests/lib/notification/notification.test.ts
@@ -89,6 +89,15 @@ describe('PushAPI.notification functionality', () => {
       expect(response).not.null;
     });
 
+
+    it('Should return feeds when signer with provider is used', async () => {
+      const response = await userKate.notification.list('SPAM', {
+        account: 'eip155:0xD8634C39BBFd4033c0d3289C4515275102423681',
+      });
+      // console.log(response)
+      expect(response).not.null;
+    });
+
     it('Should return feeds when viem is used', async () => {
       const response = await userViem.notification.list('SPAM');
       // console.log(response);
@@ -267,11 +276,18 @@ describe('PushAPI.notification functionality', () => {
       expect(response.length).not.equal(0);
     });
 
+    it('Signer with account: Should return response', async () => {
+      const response = await userKate.notification.subscriptions({
+        account: 'eip155:0xD8634C39BBFd4033c0d3289C4515275102423681',
+      });
+      expect(response).not.null;
+      expect(response.length).not.equal(0);
+    });
+
     it('Signer with account: Should return response', async () => {
       const response = await userKate.notification.subscriptions({
         account: '0xD8634C39BBFd4033c0d3289C4515275102423681',
       });
-      // console.log(JSON.stringify(response));
       expect(response).not.null;
       expect(response.length).not.equal(0);
     });
@@ -282,7 +298,6 @@ describe('PushAPI.notification functionality', () => {
         raw: false,
         channel: '0xD8634C39BBFd4033c0d3289C4515275102423681',
       });
-      console.log(JSON.stringify(response));
       expect(response).not.null;
     });
   });