Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

😈 [Improvement Proposal] - Optimize Chat.list #1090

Closed
Aman035 opened this issue Feb 5, 2024 · 0 comments · Fixed by #1115
Closed

😈 [Improvement Proposal] - Optimize Chat.list #1090

Aman035 opened this issue Feb 5, 2024 · 0 comments · Fixed by #1115
Assignees
@Aman035

Comments

@Aman035
Copy link
Member

Aman035 commented Feb 5, 2024

Proposal name

Optimize chat.list

Describe the Proposal

chat.list currently does N+1 API calls for fetching N chats

  1. Fetch lists of chat of a account with latest threadhash
  2. Fetch latest message for every chat ie N times for N chats

This can be reduced by changing the API structure of 1. to give results in 1 go

Use Case

  • Significant reduction is Fn Execution Time

Current Limitations
@Aman035 Aman035 linked a pull request Feb 14, 2024 that will close this issue
fix: optimize chat.list #1115
Merged
5 tasks
@Aman035 Aman035 self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aman035 Aman035

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: optimize chat.list push-protocol/push-sdk
1 participant
@Aman035