Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize chat.list #1115

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: optimize chat.list #1115

merged 1 commit into from
Feb 16, 2024

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Feb 14, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

  • The import statement at the top is importing all the exports from the './pgp' file. It would be better to only import the necessary exports instead of using the wildcard.
  • The import statement for the 'isValidCAIP10NFTAddress' and 'pCAIP10ToWallet' functions is importing from a '../helpers' file, but the correct file path is '../../helpers'. Please fix the file path.
  • The import statement for the 'getUser' function is importing from a '../../user' file, but there is no such file. Please check the file path.
  • The import statement for the 'CID' function is importing from a '../ipfs' file, but the correct function name is 'getCID'. Please fix the function name.
  • The function signature for 'getInboxLists' includes a default argument pgpHelper = PGP.PGPHelper, but the import statement for 'PGP' is importing as import * as PGP from './pgp'. Please either change the import statement to import the 'PGPHelper' directly, or change the function signature to accept the entire 'PGP' namespace.
  • The return type of the 'getInboxLists' function is defined as Promise<IFeeds[]>, but the actual return value in the "toDecrypt" condition is Promise<SpaceIFeeds[]>. Please make sure the return type matches the actual return value.
  • In the 'getSpaceInboxLists' function, it seems that the 'message' object is being assigned with some default values. If this is the case, it would be better to define a type/interface for the 'Message' object instead of explicitly defining all its properties.
  • In the 'addDeprecatedInfo' function, the comments mention "LAtest" instead of "Latest". Please fix the typo.
  • In the 'addDeprecatedInfo' function, there is a typo in the comment for the 'deprecatedCode' property. It says "NFT Owner Changed" when it should be "The owner of the NFT has changed". Please fix the comment.

That's all the issues I found. The code logic looks good.

@Aman035 Aman035 linked an issue Feb 14, 2024 that may be closed by this pull request
@Aman035 Aman035 merged commit 195a6e1 into main Feb 16, 2024
1 check passed
@Aman035 Aman035 deleted the optimize-list branch February 16, 2024 08:18
mohammeds1992 added a commit that referenced this pull request Feb 21, 2024
* fix: optimize chat.list (#1115)

* fix: read only guest mode

* fix: review comments

---------

Co-authored-by: Aman Gupta <guptaaman200115@gmail.com>
mohammeds1992 pushed a commit that referenced this pull request Feb 26, 2024
* fix: optimize chat.list (#1115)

* fix: allow groupImage and groupDesc to be updated to null (#1118)

* fix: mark ethers as optional peer dependency

* fix: change typeDataDomain

* fix: update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Optimize Chat.list
2 participants