Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👾 [Other] - Minor changes required in Spaces High Level SDK #1131

Closed
4 tasks done
madhur-push opened this issue Feb 29, 2024 · 1 comment · Fixed by #1136
Closed
4 tasks done

👾 [Other] - Minor changes required in Spaces High Level SDK #1131

madhur-push opened this issue Feb 29, 2024 · 1 comment · Fixed by #1136
Assignees

Comments

@madhur-push
Copy link
Contributor

madhur-push commented Feb 29, 2024

Description

  • userAliceSpace.getUserAudio() method has to be removed and it should be internally called before userAliceSpace.start() and userAliceSpace.join() (only for speaker)
  • Types, constants required for the Spaces SDK to be integrated should be exported from TYPES, CONSTANTS object, just like it has been done for Video High Level SDK.
  • In userAliceSpace.config() video param should be removed as for spaces we only need the audio stream.
  • In userAlice.space.create() method we should make isPublic as an optional param, as we havent discussed private spaces yet.

Dapp Env

Prod (app.push.org), Staging (staging.push.org), Dev (dev.push.org)

@madhur-push madhur-push self-assigned this Feb 29, 2024
@madhur-push madhur-push linked a pull request Mar 1, 2024 that will close this issue
@Aman035
Copy link
Member

Aman035 commented Apr 2, 2024

Marking this issue as complete

@Aman035 Aman035 closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants