Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes in spaces v2 SDK #1136

Merged
merged 4 commits into from
Mar 2, 2024

Conversation

madhur-push
Copy link
Contributor

No description provided.

@madhur-push madhur-push changed the title 1131 minor changes in spaces v2 sdk Minor changes in spaces v2 SDK Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

In the file packages/restapi/src/lib/constantsV2.ts:

  1. There is a missing comma after the definition of INITIAL_DATA in the VIDEO object.
  2. There is a missing comma after the definition of ENCRYPTION_TYPE in the USER object.
  3. Some comments are marked with // TODO, which indicates they are tasks or reminders, but they are not actually TODO comments.

In the file packages/restapi/src/lib/pushapi/pushAPITypes.ts:

  1. There is a missing closing curly brace } for the GroupUpdateOptions interface.
  2. There is a missing closing curly brace } for the SpaceUpdateOptions interface.
  3. There is a missing closing curly brace } for the InfoOptions interface.
  4. There is a missing closing curly brace } for the SpaceCreationOptions interface.
  5. There is a missing closing curly brace } for the SpaceQueryOptions interface.
  6. There is a missing closing curly brace } for the ParticipantStatus interface.
  7. There is a missing closing curly brace } for the SpaceParticipantStatus interface.
  8. There is a missing closing curly brace } for the SpaceInitializeOptions interface.
  9. There is a missing closing curly brace } for the VideoInitializeOptions interface.

In the file packages/restapi/src/lib/space/Space.ts:

  1. There are several commented-out methods that are not being used, consider removing them or uncommenting if necessary.
  2. There is a missing closing curly brace } for the update method.
  3. The comment for the createAudioStream method indicates it is deprecated, but the method is still present.

In the file packages/restapi/src/lib/space/SpaceV2.ts:

  1. There are missing closing curly braces } for the rejectMicRequest, inviteToPromote, acceptPromotionInvite functions.
  2. There is a missing closing curly brace } for the config function definition.

In the file packages/restapi/src/lib/space/join.ts:

  1. There is a missing closing curly brace } for the isSpeakerPending block.
  2. There is a missing closing curly brace } for the if (isSpeaker || isSpeakerPending) { block.

In the file packages/restapi/src/lib/space/start.ts:

  1. There is a missing closing curly brace } for the getSpaceAdminsList function.
  2. There is a missing closing curly brace } for the if (this.data.local.address !== pCAIP10ToWallet(space.spaceCreator)) { block.

Overall, the code needs proper closing curly braces and commas in object definitions. After correcting these issues, the code should be reviewed again to ensure it functions as expected.

All looks good.

@madhur-push madhur-push linked an issue Mar 1, 2024 that may be closed by this pull request
4 tasks
@madhur-push madhur-push self-assigned this Mar 1, 2024
@mohammeds1992 mohammeds1992 merged commit 3111be5 into alpha Mar 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👾 [Other] - Minor changes required in Spaces High Level SDK
2 participants