Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: list() method in spaces high level SDK to uses spaces(), requests() #1061

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix: list() method in spaces high level SDK to uses spaces(), requests() #1061

merged 1 commit into from
Jan 24, 2024

Conversation

madhur-push
Copy link
Contributor

No description provided.

@madhur-push madhur-push self-assigned this Jan 24, 2024
@madhur-push madhur-push linked an issue Jan 24, 2024 that may be closed by this pull request
Fix list() method in Spaces v1.5 to use PUSH_SPACE.spaces(), PUSH_SPACE.requests() #1060
Closed
@github-actions GitHub Actions
Copy link

Found mistakes/typos:

  • Line 30: Missing closing bracket after the arrow function.
  • Line 31: Missing closing parenthesis after the arrow function.

Logic check:

  • Line 31: It seems that page and limit variables are not defined in the trending method.

Suggestions:

  • Line 7: Add a return type to the search method. It is currently missing.
  • Line 32: Consider adding type annotations to the options parameter in the trending method for better code clarity.

Code review is complete.

@mohammeds1992 mohammeds1992 merged commit c8aaac7 into 897-improvement-proposal-spaces-high-level-functions Jan 24, 2024
1 check passed
@madhur-push madhur-push deleted the 1060-fix-high-level-spaces-list-method branch January 24, 2024 08:29
@madhur-push madhur-push mentioned this pull request Jan 24, 2024
Closed
mohammeds1992 added a commit that referenced this pull request Feb 7, 2024
@mohammeds1992 @madhur-push
897 improvement proposal spaces high level functions (#898)
c9ddf4d 
* fix: spaces high level

* fix: spaces high level function

* fix: spaces test cases

* fix: spaces stream changes

* fix: removed unnecessary logs

* Add spaces high level audio methods (#993)

* feat(spaces): add high level audio methods

* fix: socket url fix (#995)

* feat(spaces-highlevel-audio-methods): add media function in Spaces class

---------

Co-authored-by: Mohammed S <shoaib@push.org>

* feat(space stream): add 'start', 'stop' events (#1027)

* fix(high level spaces sdk): fix list() method to uses spaces(), requests() methods (#1061)

---------

Co-authored-by: Madhur Gupta <madhur@push.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammeds1992 mohammeds1992 mohammeds1992 approved these changes

Assignees

@madhur-push madhur-push

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix list() method in Spaces v1.5 to use PUSH_SPACE.spaces(), PUSH_SPACE.requests()
2 participants
@madhur-push @mohammeds1992