Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spaces v2): update param, method names in high level spaces SDK #1101

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

madhur-push
Copy link
Contributor

  • Rename setSpaceData to onChange in space.initialize()
  • Rename media() to config in SpacesV2

@madhur-push madhur-push self-assigned this Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

File: packages/restapi/src/lib/pushapi/pushAPITypes.ts

  • In the SpaceCreationOptions interface, the end property is optional, so it should have a question mark after it.
  • In the SpaceQueryOptions interface, the page and limit properties are required, so they should not have a question mark after them.
  • In the SpaceParticipantStatus interface, there is a typo in the role property values. It should be 'SPEAKER' and 'LISTENER' instead of 'SPEKER' and 'LISTNER'.

File: packages/restapi/src/lib/pushapi/space.ts

  • In the accept method, there is a missing closing curly brace after the reject(spaceId) call.
  • In the chat.send method, the options parameter should have type MessageOptions instead of Message.
  • In the chat.decrypt method, the messages parameter should have type IMessageIPFS[] instead of messages: IMessageIPFS.
  • In the chat.latest method, the target parameter should have type string instead of target: string.
  • In the chat.history method, the target and options parameters should not be optional, so they should not have a question mark after them.

File: packages/restapi/src/lib/space/SpaceV2.ts

  • In the acceptMicRequest method, the signal parameter should have type any instead of any: signal.
  • In the rejectMicRequest method, the address parameter should have type string instead of address: string.
  • In the inviteToPromote method, the address parameter should have type string instead of address: string.
  • In the acceptPromotionInvite method, the signal parameter should have type any instead of signal: any.
  • In the rejectPromotionInvite method, there is a misplaced closing curly brace before the method's body.
  • In the config method, there is a missing closing parenthesis after state: video and state: audio in the enableVideo and enableAudio calls respectively.

@mohammeds1992 mohammeds1992 merged commit d832ae3 into alpha Feb 8, 2024
1 check passed
@madhur-push madhur-push deleted the fix-spaces-v2-param-names branch February 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants