Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha deployment #1178

Merged
merged 73 commits into from
Mar 22, 2024
Merged

Alpha deployment #1178

merged 73 commits into from
Mar 22, 2024

Conversation

mishramonalisha76
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

mohammeds1992 and others added 30 commits January 3, 2024 13:41
Copy link

In ChatProfile.tsx:

  • Commented out chatId should be uncommented or else the component won't receive the required prop.
  • Make sure the comment format is consistent with the codebase.

In ChatViewComponent.tsx:

  • Be cautious about the commented-out CreateGroupModal component, it may have been commented out by mistake.
  • Check if the commented-out welcomeComponent prop in ChatView component is supposed to be uncommented.

In restapi/package.json:

  • There are syntax errors such as missing closing braces '}' for "peerDependencies" and "dependencies" fields and "scripts" field.
  • Verify the syntax and ensure all fields are correctly formatted in the file.

In uiweb/CHANGELOG.md:

  • The changelog file seems to be extensive and contains multiple update entries. Make sure to review that all changes and bug fixes adhere to the project requirements.

In uiweb/package.json:

  • There is a missing comma ',' after the "uuid" dependency.
  • Verify that the "peerDependencies" object is structured correctly with all dependencies listed.

In uiweb/src/lib/components/chat/CreateGroup/AddCriteria.tsx:

  • Ensure that the commented-out BLOCKCHAIN_NETWORK assignments are correctly placed and contain valid values.
  • Check if the conditions and logic for environmental checks are appropriate.
  • Review the logic for category and subCategory assignment based on the type and category values.

Overall, the code appears to have some inconsistencies, missing commas, and commented-out code that may need further validation. It's recommended to carefully review and verify all the changes to ensure the correct behavior of the components.

@mishramonalisha76 mishramonalisha76 merged commit 5f18cff into alpha Mar 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants