Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group fixes #1182

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Group fixes #1182

merged 2 commits into from
Apr 1, 2024

Conversation

mishramonalisha76
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 commented Mar 22, 2024

Fixes Issue

Fixed scrollbar in groupInfo
Whenever group is created it wasnt showing in chatPreviewList, fixed it.
Group creation without adding members, fixed the button disabled colour too

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In the file packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatPreviewList.tsx, I found the following issues:

  1. Typo in the JSX syntax with the incomplete input tag:

    <input
      type="text"
      onChange={handleAddressChange}
      value={address}
      style={{ width: 400, height: 30 }}  {/* Missing closing angle bracket */}
  2. The onChatSelected, onUnreadCountChange, onLoading, onPaging, and onPreload props of ChatPreviewList component have incorrect arrow function declarations with multiple parameters. It should be wrapped in a single object like this:

    onChatSelected={(chatid, chatParticipant) => { console.log("Chat id: ", chatid, chatParticipant) }
    // Should be changed to
    onChatSelected={({ chatid, chatParticipant }) => { console.log("Chat id: ", chatid, chatParticipant) }

In the file packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatProfile.tsx, I found one issue:

  1. The chatId prop in the ChatProfile component is commented out, and you should remove the comment to make it active.

In the file packages/uiweb/src/lib/components/chat/ChatPreviewList/ChatPreviewList.tsx, I found the following issues:

  1. The addChatItems function is missing a closing bracket.
  2. Syntax error in the removeChatItems function where the closing bracket is misplaced after the filter method.
  3. Syntax error in the transformGroupCreationStream function where the closing bracket is misplaced after the chatMsg object.
  4. Syntax error in the transformStreamMessage function where the closing bracket is misplaced after the modItem.chatParticipant = profile.groupName;.
  5. Similar syntax errors in various parts of the file such as missing closing brackets, misplaced closing brackets, and incomplete functions.

I recommend fixing these issues before proceeding. Let me know if you need further assistance.

@mishramonalisha76 mishramonalisha76 merged commit a68929c into alpha Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant