Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polygon Amoy Support #1221

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Add Polygon Amoy Support #1221

merged 3 commits into from
Apr 10, 2024

Conversation

pratham-bhatnagar
Copy link
Contributor

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

github-actions bot commented Apr 9, 2024

There are several issues I found in the code:

  1. In the Connect.tsx file:

    • The ConnectWrapper component is missing a closing curly brace } after the .network styles.
    • The StyledButton component is missing closing curly braces } after the cursor: pointer;.
    • Both Connect and Disconnect components are not properly defined. These should be functional components, not styled components.
  2. In the helpers.ts file:

    • The isValidETHAddress function is missing a closing curly brace }.
    • The validateCAIP function is missing a closing curly brace } after the return validatorFn({ address });.
    • There is a missing closing curly brace } for the AddressValidators object.
    • The AddressValidatorsType interface is missing a closing curly brace } after the function signature.
    • The ETH_CHAIN_ID constant has incorrect syntax, it should be defined as an object with keys and values.
  3. In the config.ts file:

    • There are missing closing curly braces } for several objects like polygonAmoy, berachainTestnet, and VIEM_CORE_CONFIG.
    • The ENV.LOCAL value is incorrectly referred to as a default chain ID for some chains.
    • The ALIAS_CHAIN_ID constant is missing an equal sign =.
    • The CHAIN_ID object is missing some closing curly braces }.
    • The CHAIN_ID object is missing a closing curly brace } at the end.
    • The EPNS_CORE_CONTRACT property in the VIEM_CORE_CONFIG objects is not properly formatted.
    • The TOKEN, TOKEN_VIEM_NETWORK_MAP, and SOURCE_TYPES objects have issues with syntax and formatting.

Please address these issues to ensure the code functions correctly.

@Aman035 Aman035 changed the base branch from main to alpha April 10, 2024 08:43
Copy link

In the file packages/examples/sdk-frontend-react/src/app/components/Connect.tsx:

  1. In the ConnectWrapper styled component, the closing curly brace for the .network class is missing.
  2. In the StyledButton styled component, the closing backtick and semicolon are missing.
  3. In the Connect styled component, the closing backtick and semicolon are missing.
  4. In the Disconnect styled component, the closing backtick and semicolon are missing.

All other parts of the code look good.

Therefore, the code review for Connect.tsx is completed with the above-mentioned findings.

In the file packages/examples/sdk-frontend-react/src/app/helpers.ts:

  1. The validation function isValidETHAddress is missing a closing curly brace.
  2. The eip155 function inside AddressValidatorsType is missing a closing curly brace.
  3. The validateCAIP function is missing closing curly braces.
  4. In the getFallbackETHCAIPAddress function, the comment "// Add other chains here" is missing a closing curly brace.

All other parts of the code look good.

Therefore, the code review for helpers.ts is completed with the above-mentioned findings.

All looks good in the rest of the files.

@Aman035 Aman035 changed the base branch from alpha to main April 10, 2024 08:47
@Aman035 Aman035 changed the base branch from main to alpha April 10, 2024 08:47
@Aman035 Aman035 merged commit 936ca8c into alpha Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants