Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1220 add polygon amoy support #1222

Merged
merged 5 commits into from
Apr 10, 2024
Merged

1220 add polygon amoy support #1222

merged 5 commits into from
Apr 10, 2024

Conversation

pratham-bhatnagar
Copy link
Contributor

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In File: packages/examples/sdk-frontend-react/src/app/components/Connect.tsx:

  1. margin: 20; in ConnectWrapper styles is missing the unit. It should be margin: 20px;.

In File: packages/examples/sdk-frontend-react/src/app/helpers.ts:

  1. In the AddressValidatorsType interface definition, the closing curly brace } is missing.
  2. The isValidETHAddress function is missing a closing curly brace }.
  3. The comment closing tag */ is missing after the comment block in the validateCAIP function.
  4. The validateCAIP function is missing a closing curly brace }.
  5. The eip155 property in AddressValidators doesn't have a closing brace }.
  6. The AddressValidators object is missing the closing curly brace }.

In File: packages/restapi/src/lib/config.ts:

  1. In the polygonAmoy object definition, there is a missing closing } after the testnet: true,.
  2. In the BERACHAIN object definition, blockExplorers property lacks a closing brace }.
  3. In the BERACHAIN object definition, the rpcUrls property lacks a closing brace }.
  4. ALIAS_CHAIN_ID constant should be an object, so it needs to be corrected to export const ALIAS_CHAIN_ID = {.
  5. Missing a closing curly brace } after the TOKEN object definition.
  6. ALIAS_CHAIN_ID values are incorrectly defined; the correct syntax should be an object with chain mapping within ENV like for ETH, BSC, OPTIMISM, etc.
  7. CHAIN_NAME object lacks a closing }.
  8. VIEM_CORE_CONFIG has the incorrect format. It should be defined as an object similar to the rest of the constants.
  9. Multiple declarations of EPNS_COMMUNICATOR_CONTRACT within CONFIG object.

In File: packages/restapi/src/lib/constants.ts:

  1. The comment /** @deprecated - Use MediaEmbed Instead */ has mismatched backticks. It should be escaped as \MediaEmbed` Instead `.

Please correct these issues and recheck.

@Aman035 Aman035 changed the base branch from main to alpha April 10, 2024 12:53
Copy link

In the file packages/examples/sdk-react-native/src/screens/NotificationScreen.tsx:

  1. There are multiple syntax errors within the object in the notificationItems array. Each notification item should be enclosed within curly braces {}.
  2. The notificationItems object contains duplicate keys for notificationTitle. Each object should have unique keys.
  3. Some of the notificationItems are missing the notificationBody key-value pair.

In the file packages/uiweb/src/lib/constants.ts:

  1. There are syntax errors in defining objects such as ETH_TEST_SEPOLIA, POLYGON_TEST_AMOY, OPTIMISM_MAINNET, etc. The objects are not properly formatted with closing curly braces }.

Overall, the code contains several syntax errors and incorrect object formatting.

Therefore, the correct code should be updated to resolve the syntax errors and ensure each object has unique keys in the notification items array.

All looks good.

@Aman035 Aman035 merged commit dfc1f05 into alpha Apr 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants