Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account public push api #1235

Merged
merged 198 commits into from
Apr 16, 2024
Merged

account public push api #1235

merged 198 commits into from
Apr 16, 2024

Conversation

mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In the file .husky/pre-commit, the line #yarn nx affected --target=test is commented out. If this is intentional, then everything looks good.

In the packages/restapi/CHANGELOG.md file:

  • In the entry for version 1.7.5, there is no section title. It seems there should be a "### Bug Fixes" section like other entries.
  • In the packages/restapi/package.json file:
    • The "peerDependencies" object is missing a closing curly brace }.
    • The "peerDependenciesMeta" object is missing a closing curly brace }.
    • The "dependencies" object is missing a closing curly brace }.
    • The "scripts" object is missing a closing curly brace }.
  • In the packages/restapi/src/lib/pushapi/PushAPI.ts file:
    • The constructor method is missing a closing brace }.
    • In the reinitialize method, there is a missing closing curly brace }.

After addressing these issues, the code should be correct.

@mohammeds1992 mohammeds1992 merged commit 63a4c87 into main Apr 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants