Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Referrer feild in subscriber #1255

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

pratham-bhatnagar
Copy link
Contributor

Fixes #1244

Copy link

github-actions bot commented May 1, 2024

  • In the subscribe function, the verifyingContractAddress parameter is an optional parameter, but it should not be optional in this context. Update the type definition in SubscribeOptionsType to make it required if it is needed for the logic.
  • In the subscribeV2 function, the origin parameter is optional but should be a required field for this context. Update the type definition in SubscribeOptionsV2Type to make it required.
  • In the subscribeV2 function, the messageInformation object has a property data defined, but it is not required. Ensure that the data property is always present in the messageInformation object or update the logic accordingly.
  • In the test suite, there is a commented-out test case Should subscribe to the channel via V2 with settings. This test case should be enabled or removed if no longer needed.

Apart from these points, the code logic and structure seem fine.

Code Review Comments:

  • All looks good.

@Aman035 Aman035 changed the base branch from main to alpha May 2, 2024 08:35
@Aman035 Aman035 merged commit cd650bd into alpha May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add origin in subscriber
2 participants