Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(multiple files): fixes export related terminal warning and updates yarn.lock #1267

Merged
merged 1 commit into from
May 8, 2024

Conversation

rohitmalhotra1420
Copy link
Collaborator

Changes proposed

  • The Pr updates the outdated yarn.lock files which got automatically updated upon a yarn install done after cloning the project.
  • It fixes the typescript export warning in the development build terminal as well.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

No warning in the development build terminal

Screenshot 2024-05-07 at 2 52 17 PM

Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishramonalisha76
Copy link
Collaborator

LGTM

The base branch branch needs to change from main to alpha

@rohitmalhotra1420 rohitmalhotra1420 changed the base branch from main to alpha May 8, 2024 10:07
@rohitmalhotra1420
Copy link
Collaborator Author

LGTM

The base branch branch needs to change from main to alpha

Done, could you give it a check it out once more and then we could merge it.

@mishramonalisha76
Copy link
Collaborator

LGTM

The base branch branch needs to change from main to alpha

Done, could you give it a check it out once more and then we could merge it.

Yes it can be merged now, lgtm

@rohitmalhotra1420 rohitmalhotra1420 merged commit f039900 into alpha May 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants