Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PyBaMM 22.10 #105

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Conversation

Saransh-cpp
Copy link
Member

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (42cd36b) compared to base (2269e22).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #105    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           17        12     -5     
  Lines          656       398   -258     
==========================================
- Hits           656       398   -258     
Impacted Files Coverage Δ
bot/plotting/comparison_generator.py 100.00% <100.00%> (ø)
bot/plotting/config_generator.py 100.00% <100.00%> (ø)
bot/plotting/degradation_comparison_generator.py 100.00% <100.00%> (ø)
bot/utils/degradation_parameter_generator.py 100.00% <100.00%> (ø)
bot/utils/tweet_text_generator.py 100.00% <100.00%> (ø)
bot/twitter_api/tweet_plot.py
bot/twitter_api/tweet_reply.py
bot/twitter_api/upload.py
bot/twitter_api/api_keys.py
bot/twitter_api/sync_last_seen_id.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Saransh-cpp Saransh-cpp merged commit a02aadb into pybamm-team:main Nov 2, 2022
@Saransh-cpp Saransh-cpp deleted the pybamm-22.10 branch November 2, 2022 03:52
@Saransh-cpp Saransh-cpp mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants