fix examples

pybamm-team · Aug 23, 2022 · 0c4b972 · 0c4b972
1 parent e71f30d
commit 0c4b972
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/examples/notebooks/models/using-submodels.ipynb b/examples/notebooks/models/using-submodels.ipynb
@@ -138,7 +138,7 @@
    "outputs": [],
    "source": [
     "model.submodels[\"negative primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(\n",
-    "    model.param, \"Negative\", options={**model.options, \"particle\": \"uniform profile\"}, phase=\"primary\"\n",
+    "    model.param, \"Negative\", options={**model.options, \"particle\": \"uniform profile\"}\n",
     ")"
    ]
   },
@@ -416,8 +416,8 @@
    "outputs": [],
    "source": [
     "options = {**model.options, \"particle\": \"uniform profile\"}\n",
-    "model.submodels[\"negative primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Negative\", options, \"primary\")\n",
-    "model.submodels[\"positive primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Positive\", options, \"primary\")"
+    "model.submodels[\"negative primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Negative\", options)\n",
+    "model.submodels[\"positive primary particle\"] = pybamm.particle.XAveragedPolynomialProfile(model.param, \"Positive\", options)"
    ]
   },
   {
@@ -436,12 +436,12 @@
     "model.submodels[\n",
     "    \"negative open circuit potential\"\n",
     "] = pybamm.open_circuit_potential.SingleOpenCircuitPotential(\n",
-    "    model.param, \"Negative\", \"lithium-ion main\", options=model.options, phase=\"primary\"\n",
+    "    model.param, \"Negative\", \"lithium-ion main\", options=model.options\n",
     ")\n",
     "model.submodels[\n",
     "    \"positive open circuit potential\"\n",
     "] = pybamm.open_circuit_potential.SingleOpenCircuitPotential(\n",
-    "    model.param, \"Positive\", \"lithium-ion main\", options=model.options, phase=\"primary\"\n",
+    "    model.param, \"Positive\", \"lithium-ion main\", options=model.options\n",
     ")\n",
     "model.submodels[\n",
     "    \"negative interface\"\n",
@@ -486,10 +486,10 @@
    "source": [
     "model.submodels[\n",
     "    \"Negative particle mechanics\"\n",
-    "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Negative\", model.options, \"primary\")\n",
+    "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Negative\", model.options)\n",
     "model.submodels[\n",
     "    \"Positive particle mechanics\"\n",
-    "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Positive\", model.options, \"primary\")\n",
+    "] = pybamm.particle_mechanics.NoMechanics(model.param, \"Positive\", model.options)\n",
     "model.submodels[\"sei\"] = pybamm.sei.NoSEI(model.param)\n",
     "model.submodels[\"sei on cracks\"] = pybamm.sei.NoSEI(model.param, cracks=True)\n",
     "model.submodels[\"lithium plating\"] = pybamm.lithium_plating.NoPlating(model.param)"

diff --git a/examples/scripts/custom_model.py b/examples/scripts/custom_model.py
@@ -93,10 +93,10 @@
     model.param, "Positive"
 )
 model.submodels["Negative particle mechanics"] = pybamm.particle_mechanics.NoMechanics(
-    model.param, "Negative", model.options, "primary"
+    model.param, "Negative", model.options
 )
 model.submodels["Positive particle mechanics"] = pybamm.particle_mechanics.NoMechanics(
-    model.param, "Positive", model.options, "primary"
+    model.param, "Positive", model.options
 )
 model.submodels["sei"] = pybamm.sei.NoSEI(model.param)
 model.submodels["sei on cracks"] = pybamm.sei.NoSEI(model.param, cracks=True)

diff --git a/pybamm/models/full_battery_models/lithium_ion/spm.py b/pybamm/models/full_battery_models/lithium_ion/spm.py
@@ -106,7 +106,7 @@ def set_intercalation_kinetics_submodel(self):
                             self.param, domain, "lithium-ion main", self.options, phase
                         )
 
-                    self.submodels[f"{domain} {phase} interface"] = submod
+                        self.submodels[f"{domain} {phase} interface"] = submod
                 if len(phases) > 1:
                     self.submodels[
                         f"total {domain} interface"