#1506 added tests for coverage

pybamm-team · Jul 27, 2021 · 208294b · 208294b
1 parent fdc5f99
commit 208294b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/tests/unit/test_parameters/test_lead_acid_parameters.py b/tests/unit/test_parameters/test_lead_acid_parameters.py
@@ -40,6 +40,14 @@ def test_parameters_defaults_lead_acid(self):
         self.assertGreater(
             parameter_values.evaluate(parameters.sigma_p(parameters.T_ref)), 10
         )
+
+        # Rescaled dimensionless electrode conductivities should still be large
+        self.assertGreater(
+            parameter_values.evaluate(parameters.sigma_n_prime(parameters.T_ref)), 10
+        )
+        self.assertGreater(
+            parameter_values.evaluate(parameters.sigma_p_prime(parameters.T_ref)), 10
+        )
         # Dimensionless double-layer capacity should be small
         self.assertLess(param_eval["C_dl_n"], 1e-3)
         self.assertLess(param_eval["C_dl_p"], 1e-3)

diff --git a/tests/unit/test_parameters/test_lithium_ion_parameters.py b/tests/unit/test_parameters/test_lithium_ion_parameters.py
@@ -160,17 +160,27 @@ def test_lithium_ion(self):
             values.evaluate(param.sigma_n(param.T_ref) * c_rate), 475.7, 1
         )
 
-        # neg dimensional
+        # neg dimensionless rescaled
+        np.testing.assert_almost_equal(
+            values.evaluate(param.sigma_n_prime(param.T_ref) * c_rate), 0.7814, 1
+        )
+
+        # pos dimensional
         np.testing.assert_almost_equal(
             values.evaluate(param.sigma_p_dimensional(param.T_ref)), 10, 3
         )
 
-        # neg dimensionless (old sigma_n / old_Lambda ) (this is different to values in
+        # pos dimensionless (old sigma_n / old_Lambda ) (this is different to values in
         # paper so check again, it is close enough for now though)
         np.testing.assert_almost_equal(
             values.evaluate(param.sigma_p(param.T_ref) * c_rate), 47.57, 1
         )
 
+        # pos dimensionless rescaled
+        np.testing.assert_almost_equal(
+            values.evaluate(param.sigma_p_prime(param.T_ref) * c_rate), 0.07814, 1
+        )
+
     def test_thermal_parameters(self):
         values = pybamm.lithium_ion.BaseModel().default_parameter_values
         param = pybamm.LithiumIonParameters()