Skip to content

Commit

Permalink
#1863 fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
martinjrobins committed Mar 31, 2022
1 parent 2b39a67 commit 3259c2b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 3 deletions.
3 changes: 2 additions & 1 deletion pybamm/solvers/idaklu_solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ def resfn(t, y, inputs, ydot):
)

else:
jac_y0_t0 = model.jac_rhs_algebraic_eval(t_eval[0], y0, inputs_dict)
t0 = 0 if t_eval is None else t_eval[0]
jac_y0_t0 = model.jac_rhs_algebraic_eval(t0, y0, inputs_dict)
if sparse.issparse(jac_y0_t0):
def jacfn(t, y, inputs, cj):
j = (
Expand Down
11 changes: 9 additions & 2 deletions tests/unit/test_solvers/test_base_solver.py
Original file line number Diff line number Diff line change
Expand Up @@ -377,11 +377,18 @@ def exact_diff_b(y, a, b):

sens = model.jacp_rhs_algebraic_eval(t, y, use_inputs)

if convert_to_format == "casadi":
sens_a = sens[0]
sens_b = sens[1]
else:
sens_a = sens["a"]
sens_b = sens["b"]

np.testing.assert_allclose(
sens["a"], exact_diff_a(y, inputs["a"], inputs["b"])
sens_a, exact_diff_a(y, inputs["a"], inputs["b"])
)
np.testing.assert_allclose(
sens["b"], exact_diff_b(y, inputs["a"], inputs["b"])
sens_b, exact_diff_b(y, inputs["a"], inputs["b"])
)


Expand Down

0 comments on commit 3259c2b

Please sign in to comment.