Skip to content

Commit

Permalink
Merge pull request #3467 from abillscmu/bugfix/initial_soh
Browse files Browse the repository at this point in the history
  • Loading branch information
valentinsulzer authored and Saransh-cpp committed Oct 31, 2023
1 parent a941307 commit 37dfe89
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ElectrodeSOHHalfCell(pybamm.BaseModel):
"""

def __init__(self, name="Electrode-specific SOH model"):
def __init__(self, name="ElectrodeSOH model"):
pybamm.citations.register("Mohtat2019")
super().__init__(name)
param = pybamm.LithiumIonParameters({"working electrode": "positive"})
Expand Down Expand Up @@ -140,7 +140,7 @@ def get_min_max_stoichiometries(
parameter_values : pybamm.ParameterValues
The parameter values to use in the calculation
"""
esoh_model = pybamm.lithium_ion.ElectrodeSOHHalfCell(options)
esoh_model = pybamm.lithium_ion.ElectrodeSOHHalfCell("ElectrodeSOH")
param = pybamm.LithiumIonParameters(options)
esoh_sim = pybamm.Simulation(esoh_model, parameter_values=parameter_values)
Q_w = parameter_values.evaluate(param.p.Q_init)
Expand Down
2 changes: 1 addition & 1 deletion pybamm/simulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ def solve(
)
if (
self.operating_mode == "without experiment"
or self._model.name == "ElectrodeSOH model"
or "ElectrodeSOH" in self._model.name
):
if t_eval is None:
raise pybamm.SolverError(
Expand Down

0 comments on commit 37dfe89

Please sign in to comment.