Skip to content

Commit

Permalink
Deleted legacy parameters beta_sei and beta_plating
Browse files Browse the repository at this point in the history
  • Loading branch information
DrSOKane committed Aug 15, 2022
1 parent 86c1608 commit 7e529b1
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Added new parameter `Ratio of lithium moles to SEI moles` (short name z_sei) to fix a bug where this number was incorrectly hardcoded to 1. ([#2222](https://github.com/pybamm-team/PyBaMM/pull/2222))
- Changed short name of parameter `Inner SEI reaction proportion` from alpha_SEI to inner_sei_proportion, to avoid confusion with transfer coefficients. ([#2222](https://github.com/pybamm-team/PyBaMM/pull/2222))
- Deleted legacy parameters with short names beta_sei and beta_plating. ([#2222](https://github.com/pybamm-team/PyBaMM/pull/2222))
- Corrected initial SEI thickness for OKane2022 parameter set. ([#2218](https://github.com/pybamm-team/PyBaMM/pull/2218))

## Optimizations
Expand Down
6 changes: 0 additions & 6 deletions pybamm/parameters/lithium_ion_parameters.py
Original file line number Diff line number Diff line change
Expand Up @@ -412,9 +412,6 @@ def _set_dimensionless_parameters(self):

self.c_sei_init = self.c_ec_0_dim / self.c_sei_outer_scale

# I don't think this gets used anywhere?
self.beta_sei = self.n.a_typ * self.L_sei_0_dim * self.Gamma_SEI

# lithium plating parameters
self.c_plated_Li_0 = self.c_plated_Li_0_dim / self.c_Li_typ

Expand All @@ -426,9 +423,6 @@ def _set_dimensionless_parameters(self):
self.F * self.c_Li_typ
)

# Does this get used anywhere?
self.beta_plating = self.Gamma_plating * self.V_bar_plated_Li * self.c_Li_typ

# Initial conditions
self.c_e_init = self.c_e_init_dimensional / self.c_e_typ
self.ocv_init = (self.ocv_init_dim - self.ocv_ref) / self.potential_scale
Expand Down

0 comments on commit 7e529b1

Please sign in to comment.