fix tests

pybamm-team · Nov 17, 2021 · e52a1bb · e52a1bb
1 parent a203d6c
commit e52a1bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/pybamm/models/full_battery_models/base_battery_model.py b/pybamm/models/full_battery_models/base_battery_model.py
@@ -848,6 +848,9 @@ def set_thermal_submodel(self):
                 thermal_submodel = pybamm.thermal.pouch_cell.CurrentCollector2D(
                     self.param
                 )
+        elif self.options["thermal"] == "x-full":
+            if self.options["dimensionality"] == 0:
+                thermal_submodel = pybamm.thermal.OneDimensionalX(self.param)
 
         self.submodels["thermal"] = thermal_submodel
 

diff --git a/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py b/tests/unit/test_models/test_full_battery_models/test_lead_acid/test_base_lead_acid_model.py
@@ -19,11 +19,6 @@ def test_default_geometry(self):
         self.assertEqual(model.default_geometry["current collector"][var.y]["min"], 0)
 
     def test_incompatible_options(self):
-        with self.assertRaisesRegex(
-            pybamm.OptionError,
-            "Lead-acid models can only have thermal effects if dimensionality is 0.",
-        ):
-            pybamm.lead_acid.BaseModel({"dimensionality": 1, "thermal": "x-full"})
         with self.assertRaisesRegex(pybamm.OptionError, "SEI"):
             pybamm.lead_acid.BaseModel({"SEI": "constant"})
         with self.assertRaisesRegex(pybamm.OptionError, "lithium plating"):