Skip to content

Commit

Permalink
#1781 coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
valentinsulzer committed Nov 24, 2021
1 parent 955bcbe commit e9d1dc5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
6 changes: 0 additions & 6 deletions pybamm/models/full_battery_models/base_battery_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -349,12 +349,6 @@ def __init__(self, extra_options):
"mechanics model"
)

if options["thermal"] == "x-full" and options["dimensionality"] != 0:
n = options["dimensionality"]
raise pybamm.OptionError(
f"X-full thermal submodels do not yet support {n}D current collectors"
)

for option, value in options.items():
if option == "external submodels" or option == "working electrode":
pass
Expand Down
3 changes: 0 additions & 3 deletions pybamm/models/submodels/interface/base_interface.py
Original file line number Diff line number Diff line change
Expand Up @@ -611,9 +611,6 @@ def _get_standard_overpotential_variables(self, eta_r):

# X-average, and broadcast if necessary
eta_r_av = pybamm.x_average(eta_r)
if self.half_cell and self.domain == "Negative":
# Half-cell domain, eta should not be broadcast
pass
elif eta_r.domain == ["current collector"]:
eta_r = pybamm.PrimaryBroadcast(eta_r, self.domain_for_broadcast)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,10 @@ def test_well_posed_current_driven_utilisation(self):
options = {"interface utilisation": "current-driven"}
self.check_well_posedness(options)

def test_well_posed_mixed_utilisation(self):
options = {"interface utilisation": ("current-driven", "constant")}
self.check_well_posedness(options)

def test_well_posed_loss_active_material_stress_negative(self):
options = {"loss of active material": ("stress-driven", "none")}
self.check_well_posedness(options)
Expand Down

0 comments on commit e9d1dc5

Please sign in to comment.