Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints interpolate 2D processed variable #1087

Closed
brosaplanella opened this issue Jun 29, 2020 · 0 comments · Fixed by #1088
Closed

Add endpoints interpolate 2D processed variable #1087

brosaplanella opened this issue Jun 29, 2020 · 0 comments · Fixed by #1088
Assignees

Comments

@brosaplanella
Copy link
Sponsor Member

Describe the bug
When interpolating a 2D processed variable (e.g. particle concentration) you can't obtain the endpoints (e.g. surface concentration) as it extrapolates

To Reproduce
Steps to reproduce the behaviour:

  1. Run a simulation
  2. Generate "Positive particle concentration [mol.m-3]" processed variable
  3. Evaluate at r=0
  4. You should get a NaN

Expected behaviour
Processed variables should provide boundary values in 2D as they do in 1D.

@brosaplanella brosaplanella self-assigned this Jun 29, 2020
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 29, 2020
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 29, 2020
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 29, 2020
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant