Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add erf and erfc functions #1183

Closed
brosaplanella opened this issue Oct 3, 2020 · 2 comments · Fixed by #1184
Closed

Add erf and erfc functions #1183

brosaplanella opened this issue Oct 3, 2020 · 2 comments · Fixed by #1184
Assignees
@brosaplanella

Comments

@brosaplanella
Copy link
Sponsor Member

Summary
Add the error function (erf) and complementary error function (erfc) to PyBaMM.

Motivation
These functions come up in some applications (e.g. Stefan problems) and it would good to have them into PyBaMM. Should be an easy implementation, however it would require calling SciPy from functions.py. Would that be an issue?
@valentinsulzer
Copy link
Member

That would be fine, the only question is whether casadi has those functions

@brosaplanella
Copy link
Sponsor Member Author

It has erf. If we define the PyBaMM function Erfc as 1 - Erf then Casadi should be able to cope with it, right?

brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 7, 2020
@brosaplanella
pybamm-team#1183 added functions and tests
3026d20
@brosaplanella brosaplanella self-assigned this Oct 7, 2020
@brosaplanella brosaplanella mentioned this issue Oct 7, 2020
Merged
6 tasks
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 7, 2020
@brosaplanella
pybamm-team#1183 removed Erfc class (Tino's comments)
a3c2cfa
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 7, 2020
@brosaplanella
pybamm-team#1183 update CHANGELOG
ede73ee
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 16, 2020
@brosaplanella
pybamm-team#1183 added assert_casadi_almost_equal for erf
7041b57
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 16, 2020
@brosaplanella
pybamm-team#1183 changed tolerance assert_casadi_almost_equal
25ea09a
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Oct 16, 2020
@brosaplanella
pybamm-team#1183 removed erf from assert_equal testing
734745b
valentinsulzer added a commit that referenced this issue Oct 16, 2020
@valentinsulzer
Merge pull request #1184 from brosaplanella/issue-1183-erf
9b4c54d 
#1183 added erf and erfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosaplanella brosaplanella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1183 added erf and erfc brosaplanella/PyBaMM
2 participants
@valentinsulzer @brosaplanella