Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement electrolyte overpotentials for full_conductivity model #1349

Closed
brosaplanella opened this issue Feb 1, 2021 · 0 comments · Fixed by #1350
Closed

Implement electrolyte overpotentials for full_conductivity model #1349

brosaplanella opened this issue Feb 1, 2021 · 0 comments · Fixed by #1350
Assignees
@brosaplanella

Comments

@brosaplanella
Copy link
Sponsor Member

Summary
Implement the definitions of electrolyte overpotentials for the full_conductivity model.
@brosaplanella brosaplanella self-assigned this Feb 1, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 1, 2021
@brosaplanella
pybamm-team#1349 added concentration overpotential and ohmic losses t…
a3cc32c 
…o full_conductivity
@brosaplanella brosaplanella mentioned this issue Feb 1, 2021
Merged
8 tasks
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 1, 2021
@brosaplanella
pybamm-team#1349 fix tests
579dc1f
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 1, 2021
@brosaplanella
pybamm-team#1349 Tino's comment
b6657c4
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 2, 2021
@brosaplanella
pybamm-team#1349 fixed codacy
1c4bf03
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 2, 2021
@brosaplanella
pybamm-team#1349 fixed surface form
aeaa445
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 2, 2021
@brosaplanella
pybamm-team#1349 fix tests
05a040c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 2, 2021
@brosaplanella
pybamm-team#1349 Rob's suggestion
d4a1cdd
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Feb 2, 2021
@brosaplanella
pybamm-team#1349 update CHANGELOG
322c432
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosaplanella brosaplanella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Electrolyte overpotentials brosaplanella/PyBaMM
1 participant
@brosaplanella