Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LG M50 thermal parameter set from O'Regan 2021 #1594

Closed
brosaplanella opened this issue Aug 4, 2021 · 0 comments · Fixed by #1598
Closed

Add LG M50 thermal parameter set from O'Regan 2021 #1594

brosaplanella opened this issue Aug 4, 2021 · 0 comments · Fixed by #1598
Assignees
@brosaplanella

Comments

@brosaplanella
Copy link
Sponsor Member

Summary
Add the parameter set for the LG M50 (including temperature dependence) from the O'Regan 2021 paper (in progress).
@brosaplanella brosaplanella self-assigned this Aug 4, 2021
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 4, 2021
@brosaplanella
pybamm-team#1594 add parameter values
5c9b019
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 4, 2021
@brosaplanella
pybamm-team#1594 added parameter set and citation
873c57c
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 9, 2021
@brosaplanella
pybamm-team#1594 fix entropic term
adc8bd1
@brosaplanella brosaplanella mentioned this issue Aug 9, 2021
Merged
6 tasks
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 10, 2021
@brosaplanella
pybamm-team#1594 final minor changes in parameter values
fe4f362
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 10, 2021
@brosaplanella
pybamm-team#1594 update references to O'Regan2021
f161b29
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 10, 2021
@brosaplanella
pybamm-team#1594 fix annotations certain parameters
1488a36
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 10, 2021
@brosaplanella
pybamm-team#1594 correction positive diffusivity
c073c38
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 12, 2021
@brosaplanella
pybamm-team#1594 fix diffusivity
9cb237a
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 12, 2021
@brosaplanella
pybamm-team#1594 add tests
042172d
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 12, 2021
@brosaplanella
pybamm-team#1594 remove return Scalar
5ac74d3
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 13, 2021
@brosaplanella
pybamm-team#1594 update CHANGELOG
c4c2949
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 16, 2021
@brosaplanella
pybamm-team#1594 Rob's comments
0d5c4a7
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 16, 2021
@brosaplanella
pybamm-team#1594 add example notebook
6e72c7d
brosaplanella added a commit to brosaplanella/PyBaMM that referenced this issue Aug 20, 2021
@brosaplanella
pybamm-team#1594 shortened solving time in example notebook
d5d59bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brosaplanella brosaplanella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 1594 add O'Regan 2021 parameters brosaplanella/PyBaMM
1 participant
@brosaplanella