Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stress-induced diffusion should be optional #1748

Closed
sravanpannala opened this issue Oct 15, 2021 · 1 comment · Fixed by #1797
Closed

Stress-induced diffusion should be optional #1748

sravanpannala opened this issue Oct 15, 2021 · 1 comment · Fixed by #1797
Assignees

Comments

@sravanpannala
Copy link

  • PyBaMM version - 21.9:
  • Python version - 3.9.7:

Describe the bug
Stress-induced diffusion should be option given to the user rather than enabling it by default when the "stress-driven' degradation model is activated.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to this file
  2. Click on the fiel
  3. Scroll down to def D_n_dimensional(self, sto, T)
  4. See stress-induced diffusion modifier

Additional context
This part of the code should be optional and not hardcoded. Also, this code should not be in this file and rather in a submodel file.

@rtimms
Copy link
Contributor

rtimms commented Oct 15, 2021

Yeah, we should pass options to the particle models and define the flux differently based on the options.

@rtimms rtimms self-assigned this Nov 9, 2021
rtimms added a commit that referenced this issue Nov 10, 2021
rtimms added a commit that referenced this issue Nov 10, 2021
rtimms added a commit that referenced this issue Nov 10, 2021
rtimms added a commit that referenced this issue Nov 11, 2021
rtimms added a commit that referenced this issue Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants