Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better error about the new "exchange-current density for lithium metal electrode [A.m-2]" parameter #3428

Closed
valentinsulzer opened this issue Oct 9, 2023 · 2 comments · Fixed by #3445
Closed

Add better error about the new "exchange-current density for lithium metal electrode [A.m-2]" parameter #3428

valentinsulzer opened this issue Oct 9, 2023 · 2 comments · Fixed by #3445
Assignees
@agriyakhetarpal
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: high To be resolved as soon as possible

Comments

@valentinsulzer
Copy link
Member

It used to be "Exchange-current density for plating [A.m-2]", now renamed to "Exchange-current density for lithium metal electrode [A.m-2]". I understand why the change was made, but we should catch this in the ParameterValues class and throw an informative error
@valentinsulzer
Copy link
Member Author

This should be done before the final release 23.9

@valentinsulzer valentinsulzer added difficulty: easy A good issue for someone new. Can be done in a few hours priority: high To be resolved as soon as possible labels Oct 9, 2023
@agriyakhetarpal
Copy link
Member

Happy to take this

@agriyakhetarpal agriyakhetarpal self-assigned this Oct 9, 2023
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Oct 9, 2023
@agriyakhetarpal
pybamm-team#3428 raise error on exchange-current density for plating …
8c7157b 
…parameter
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Oct 9, 2023
@agriyakhetarpal
pybamm-team#3428 check if error is raised + coverage
ae7dc73
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Oct 9, 2023
@agriyakhetarpal
pybamm-team#3428 rename all instances of "plating" to "lithium-metal …
92e2a4f 
…electrode"
@agriyakhetarpal agriyakhetarpal mentioned this issue Oct 9, 2023
Closed
6 tasks
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Oct 9, 2023
@agriyakhetarpal
pybamm-team#3428 add a CHANGELOG entry
39e52a0
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Oct 9, 2023
@agriyakhetarpal
pybamm-team#3428 fix test, add units to error check
5d917fb
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Oct 10, 2023
@agriyakhetarpal
pybamm-team#3428 oops, un-swap parameters to raise error with
5607acb
agriyakhetarpal added a commit to agriyakhetarpal/PyBaMM that referenced this issue Oct 10, 2023
@agriyakhetarpal
pybamm-team#3428 use assertRaises instead of assertRaisesRegex
c1ac296
valentinsulzer added a commit that referenced this issue Oct 12, 2023
@valentinsulzer
#3428 exchange-current density error
a064a8a
@valentinsulzer valentinsulzer mentioned this issue Oct 12, 2023
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Oct 16, 2023
@valentinsulzer
Merge pull request #3445 from pybamm-team/issue-3428-rename-exchange
8429903 
#3428 exchange-current density error
Saransh-cpp pushed a commit that referenced this issue Oct 17, 2023
@valentinsulzer @Saransh-cpp
Merge pull request #3445 from pybamm-team/issue-3428-rename-exchange
211778b 
#3428 exchange-current density error
rtimms added a commit that referenced this issue May 16, 2024
@valentinsulzer @brosaplanella
@Saransh-cpp @martinjrobins @agriyakhetarpal @kratman @rtimms
add temperature dependence to MSMR model (#3832)
33d9ea7 
* Bump to v23.9rc0

* Merge pull request #3412 from agriyakhetarpal/drop-i686-manylinux2014-support

Drop support for i686 manylinux

* Merge pull request #3413 from Saransh-cpp/improve-release-workflow

Improve release workflow, add a note, bump version manually

* Merge pull request #3436 from Saransh-cpp/fortnightly-wheels

Build wheels on the 1st and 15th of every month

* Merge pull request #3445 from pybamm-team/issue-3428-rename-exchange

#3428 exchange-current density error

* Merge pull request #3449 from pybamm-team/i3431-windows-wheels

Fix failing windows wheel builds

* Merge pull request #3456 from abillscmu/issue-3224-initial_soc

make initial soc work with half cell models

* Merge pull request #3467 from abillscmu/bugfix/initial_soh

* Merge pull request #3423 from jsbrittain/jax_gpu

JaxSolver fails when using GPU support with no input parameters

* Fix changelog

* Merge pull request #3475 from arjxn-py/fix-default-imports

Resolve default imports for optional dependencies

* Bump - `v23.9rc1`

* Fix date in CHANGELOG

* Bump version to v23.9

* Fix docs about Jax solver compatibility with Python versions (#3702)

* Ensure correct Python versions for Jax solver compatibility

* Simplify array of Python versions

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Use different conjunction

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Merge pull request #3706 from agriyakhetarpal/fix-pybamm-install-odes

Make `pybamm_install_odes` a bit more robust

* #3690 fix issue with skipped steps (#3708)

* #3690 fix issue with skipped steps

* #3690 changelog

* #3690 add test

* #3611 use actual cell volume for average total heating (#3707)

* #3611 use actual cell volume for average total heating

* #3611 changelog

* #3611 account for number of electrode pairs

* #3611 update variable names

* Improve the release workflow (#3737)

* Try fixing the release workflow

* Turn off safety

* Fix CHANGELOG

* Add OS

* Use regex for better matches

* Update instructions, add safety checks

* checkout to the version branch for the final release

* Bump to v24.1rc1

* #3630 fix interpolant shape error (#3761)

* #3630 fix interpolant shape error

* #3630 changelog

* Bump to v24.1rc2

* Bump to v24.1

* Fix doctests failures in scheduled tests (#3784)

Closes #3781

* Resolve broken `scikits.odes` installation on self-hosted M-series runner (#3785)

* Try fixing M-series runner tests

This is being done by adding SuiteSparse and SUNDIALS installations which might have been missing on the runner, which broke `scikits.odes`.

* Don't use Homebrew SUNDIALS, use LD_LIBRARY_PATH

* Don't use Homebrew to install SUNDIALS

* Force remove pip cache for `scikits.odes`

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* add temperature dependence to MSMR model

* changelog

* fix tests

* fix example

* rob comments

* update notebook

---------

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Martin Robinson <martinjrobins@gmail.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
Co-authored-by: Saransh-cpp <Saransh-cpp@users.noreply.github.com>
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@valentinsulzer @brosaplanella
@Saransh-cpp @martinjrobins @agriyakhetarpal @kratman @rtimms @js1tr3
add temperature dependence to MSMR model (pybamm-team#3832)
4b564de 
* Bump to v23.9rc0

* Merge pull request pybamm-team#3412 from agriyakhetarpal/drop-i686-manylinux2014-support

Drop support for i686 manylinux

* Merge pull request pybamm-team#3413 from Saransh-cpp/improve-release-workflow

Improve release workflow, add a note, bump version manually

* Merge pull request pybamm-team#3436 from Saransh-cpp/fortnightly-wheels

Build wheels on the 1st and 15th of every month

* Merge pull request pybamm-team#3445 from pybamm-team/issue-3428-rename-exchange

pybamm-team#3428 exchange-current density error

* Merge pull request pybamm-team#3449 from pybamm-team/i3431-windows-wheels

Fix failing windows wheel builds

* Merge pull request pybamm-team#3456 from abillscmu/issue-3224-initial_soc

make initial soc work with half cell models

* Merge pull request pybamm-team#3467 from abillscmu/bugfix/initial_soh

* Merge pull request pybamm-team#3423 from jsbrittain/jax_gpu

JaxSolver fails when using GPU support with no input parameters

* Fix changelog

* Merge pull request pybamm-team#3475 from arjxn-py/fix-default-imports

Resolve default imports for optional dependencies

* Bump - `v23.9rc1`

* Fix date in CHANGELOG

* Bump version to v23.9

* Fix docs about Jax solver compatibility with Python versions (pybamm-team#3702)

* Ensure correct Python versions for Jax solver compatibility

* Simplify array of Python versions

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Use different conjunction

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* Merge pull request pybamm-team#3706 from agriyakhetarpal/fix-pybamm-install-odes

Make `pybamm_install_odes` a bit more robust

* pybamm-team#3690 fix issue with skipped steps (pybamm-team#3708)

* pybamm-team#3690 fix issue with skipped steps

* pybamm-team#3690 changelog

* pybamm-team#3690 add test

* pybamm-team#3611 use actual cell volume for average total heating (pybamm-team#3707)

* pybamm-team#3611 use actual cell volume for average total heating

* pybamm-team#3611 changelog

* pybamm-team#3611 account for number of electrode pairs

* pybamm-team#3611 update variable names

* Improve the release workflow (pybamm-team#3737)

* Try fixing the release workflow

* Turn off safety

* Fix CHANGELOG

* Add OS

* Use regex for better matches

* Update instructions, add safety checks

* checkout to the version branch for the final release

* Bump to v24.1rc1

* pybamm-team#3630 fix interpolant shape error (pybamm-team#3761)

* pybamm-team#3630 fix interpolant shape error

* pybamm-team#3630 changelog

* Bump to v24.1rc2

* Bump to v24.1

* Fix doctests failures in scheduled tests (pybamm-team#3784)

Closes pybamm-team#3781

* Resolve broken `scikits.odes` installation on self-hosted M-series runner (pybamm-team#3785)

* Try fixing M-series runner tests

This is being done by adding SuiteSparse and SUNDIALS installations which might have been missing on the runner, which broke `scikits.odes`.

* Don't use Homebrew SUNDIALS, use LD_LIBRARY_PATH

* Don't use Homebrew to install SUNDIALS

* Force remove pip cache for `scikits.odes`

---------

Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>

* add temperature dependence to MSMR model

* changelog

* fix tests

* fix example

* rob comments

* update notebook

---------

Co-authored-by: Ferran Brosa Planella <Ferran.Brosa-Planella@warwick.ac.uk>
Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
Co-authored-by: Martin Robinson <martinjrobins@gmail.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
Co-authored-by: Saransh-cpp <Saransh-cpp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agriyakhetarpal agriyakhetarpal

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: high To be resolved as soon as possible
Projects
None yet
Milestone
No milestone
2 participants
@valentinsulzer @agriyakhetarpal