Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage tests failing #3946

Closed
agriyakhetarpal opened this issue Mar 30, 2024 · 1 comment · Fixed by #3954
Closed

Coverage tests failing #3946

agriyakhetarpal opened this issue Mar 30, 2024 · 1 comment · Fixed by #3954
Assignees
@kratman
Labels
priority: high To be resolved as soon as possible

Comments

@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented Mar 30, 2024 •
edited
Loading

with these logs: https://github.com/pybamm-team/PyBaMM/actions/runs/8492411887/job/23265381415

perhaps #3857 was what broke it? It seems to be running okay with unittest from earlier
@agriyakhetarpal agriyakhetarpal added the priority: high To be resolved as soon as possible label Mar 30, 2024
@kratman
Copy link
Contributor

kratman commented Apr 1, 2024

Fixing this now

@kratman kratman self-assigned this Apr 1, 2024
@kratman kratman mentioned this issue Apr 1, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kratman kratman

Labels
priority: high To be resolved as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix coverage kratman/PyBaMM
2 participants
@kratman @agriyakhetarpal