Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage #3954

Merged
merged 6 commits into from
Apr 1, 2024
Merged

Fix coverage #3954

merged 6 commits into from
Apr 1, 2024

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Apr 1, 2024

Description

Minor fix to the coverage tests

Fixes #3946

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kratman kratman mentioned this pull request Apr 1, 2024
5 tasks
@agriyakhetarpal
Copy link
Member

This is pretty confusing, it passes for me locally on macOS + Python 3.11. Not sure what is going on here

@kratman
Copy link
Contributor Author

kratman commented Apr 1, 2024

Not really sure, but it is all in the latex parsing. PyCharm also flags them

@kratman
Copy link
Contributor Author

kratman commented Apr 1, 2024

I would just scan with PyCharm, but it shows 30-50 warnings/errors per file. Too much to do all at once

@kratman kratman requested review from a team and TomTranter as code owners April 1, 2024 21:58
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (3b39e9b) to head (364f0a4).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3954   +/-   ##
========================================
  Coverage    99.58%   99.58%           
========================================
  Files          257      257           
  Lines        21190    21196    +6     
========================================
+ Hits         21102    21108    +6     
  Misses          88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kratman
Copy link
Contributor Author

kratman commented Apr 1, 2024

@agriyakhetarpal can you rereview

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much thanks, this was pretty tedious

@agriyakhetarpal agriyakhetarpal merged commit 78b7d25 into pybamm-team:develop Apr 1, 2024
46 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/coverage branch April 1, 2024 23:41
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage tests failing
3 participants