-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage #3954
Fix coverage #3954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This is pretty confusing, it passes for me locally on macOS + Python 3.11. Not sure what is going on here |
Not really sure, but it is all in the latex parsing. PyCharm also flags them |
I would just scan with PyCharm, but it shows 30-50 warnings/errors per file. Too much to do all at once |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3954 +/- ##
========================================
Coverage 99.58% 99.58%
========================================
Files 257 257
Lines 21190 21196 +6
========================================
+ Hits 21102 21108 +6
Misses 88 88 ☔ View full report in Codecov by Sentry. |
@agriyakhetarpal can you rereview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much thanks, this was pretty tedious
Description
Minor fix to the coverage tests
Fixes #3946
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all
(or$ nox -s tests
)$ python run-tests.py --doctest
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick
(or$ nox -s quick
).Further checks: