Better error on unrecognised parameter set #4120
Labels
difficulty: easy
A good issue for someone new. Can be done in a few hours
Comments
agriyakhetarpal
added
the
difficulty: easy
Ubham16
pushed a commit
to Ubham16/PyBaMM
that referenced
this issue
Jun 24, 2024
rtimms
added a commit
that referenced
this issue
Jun 25, 2024
* #4120 improved error message * style: pre-commit fixes * updated test * Update tests/unit/test_parameters/test_parameter_values.py Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * Update pybamm/parameters/parameter_values.py Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com> * Update pybamm/parameters/parameter_values.py Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> --------- Co-authored-by: Ubham16 <you@example.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com> Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
js1tr3
pushed a commit
to js1tr3/PyBaMM
that referenced
this issue
Aug 12, 2024
* pybamm-team#4120 improved error message * style: pre-commit fixes * updated test * Update tests/unit/test_parameters/test_parameter_values.py Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> * Update pybamm/parameters/parameter_values.py Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com> * Update pybamm/parameters/parameter_values.py Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> --------- Co-authored-by: Ubham16 <you@example.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Arjun Verma <arjunverma.oc@gmail.com> Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com> Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Doing
pybamm.ParameterValues("bad")givesValueError: Invalid Parameter Value. It would be better to say something likeValueError: 'bad' is not a recognised parameter setand possibly list the valid options (including custom parameter sets that have been registered as entry points).The text was updated successfully, but these errors were encountered: