Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with NumPy v2 #4183

Open
agriyakhetarpal opened this issue Jun 16, 2024 · 2 comments · Fixed by #4196
Open

Compatibility with NumPy v2 #4183

agriyakhetarpal opened this issue Jun 16, 2024 · 2 comments · Fixed by #4196
Labels
priority: high To be resolved as soon as possible

Comments

@agriyakhetarpal
Copy link
Member

NumPy version 2.0.0 has been released today – we'll need to fix the failing unit tests. The tests are coming from autograd and the authors mention that they don't intend to maintain the dependency anymore so we should aim to remove it altogether, either now or later
@agriyakhetarpal agriyakhetarpal added the priority: high To be resolved as soon as possible label Jun 16, 2024
@agriyakhetarpal
Copy link
Member Author

agriyakhetarpal commented Jun 16, 2024 •
edited
Loading

As discussed, can be done after the release of v24.5rc0 with an upper pin on NumPy and that can be then removed after v24.5rc1 or with v24.9

@kratman kratman mentioned this issue Jun 17, 2024
Merged
6 tasks
valentinsulzer added a commit that referenced this issue Jun 18, 2024
@valentinsulzer
#4183 remove autograd
666081d
@valentinsulzer valentinsulzer mentioned this issue Jun 18, 2024
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Jun 21, 2024
@valentinsulzer
Merge pull request #4196 from pybamm-team/issue-4183-remove-autograd
205ca81 
#4183 remove autograd
@brosaplanella
Copy link
Sponsor Member

@valentinsulzer shall we reopen this one?

@brosaplanella brosaplanella reopened this Jun 24, 2024
js1tr3 pushed a commit to js1tr3/PyBaMM that referenced this issue Aug 12, 2024
@valentinsulzer @js1tr3
pybamm-team#4183 remove autograd
f98f933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high To be resolved as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4183 remove autograd pybamm-team/PyBaMM
2 participants
@brosaplanella @agriyakhetarpal