Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Particle Size Distribution for DFN #744

Closed
suhaklee opened this issue Nov 22, 2019 · 0 comments · Fixed by #745
Closed

Particle Size Distribution for DFN #744

suhaklee opened this issue Nov 22, 2019 · 0 comments · Fixed by #745

Comments

@suhaklee
Copy link
Contributor

Summary
Adding particle size distribution in x for DFN model

Motivation
Particle size is actually different from particle to particle.

Additional context
suhaklee added a commit to suhaklee/PyBaMM that referenced this issue Nov 22, 2019
@suhaklee
pybamm-team#744-particle size distribution
8fc9e9a
suhaklee added a commit to suhaklee/PyBaMM that referenced this issue Nov 22, 2019
@suhaklee
pybamm-team#744-added Functions for particle size distribution
726d3da
suhaklee added a commit to suhaklee/PyBaMM that referenced this issue Nov 22, 2019
@suhaklee
pybamm-team#744 add distributions into variables
4ee5305
@suhaklee suhaklee mentioned this issue Nov 22, 2019
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Nov 22, 2019
@valentinsulzer
#744 add ones_like
c0bc689
valentinsulzer added a commit that referenced this issue Nov 25, 2019
@valentinsulzer
#744 reformatting against outer
9d84122
valentinsulzer added a commit that referenced this issue Dec 7, 2019
@valentinsulzer
#744 merge #746
ac98fb5
valentinsulzer added a commit that referenced this issue Dec 11, 2019
@valentinsulzer
#744 special case for ones_like
73308dc
valentinsulzer added a commit to suhaklee/PyBaMM that referenced this issue Dec 11, 2019
@valentinsulzer
pybamm-team#744 fix more tests
c70ae39
valentinsulzer added a commit to suhaklee/PyBaMM that referenced this issue Dec 11, 2019
@valentinsulzer
pybamm-team#744 add test for ones_like
0a32edd
valentinsulzer added a commit to suhaklee/PyBaMM that referenced this issue Dec 11, 2019
@valentinsulzer
pybamm-team#744 add tests for ones_like
9457d07
valentinsulzer added a commit to suhaklee/PyBaMM that referenced this issue Dec 12, 2019
@valentinsulzer
pybamm-team#744 update Changelog
e3c252c
valentinsulzer added a commit to suhaklee/PyBaMM that referenced this issue Dec 13, 2019
@valentinsulzer
pybamm-team#744 rob comments and new test
12b04bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 744 particledistribution suhaklee/PyBaMM
1 participant
@suhaklee