-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to QuickPlot
#871
Comments
My thoughts are:
Some additional ideas that are non essential but might be nice:
Another thought though this really is just extra. It might be nice to have helper functions in simulation:
|
My thoughts:
|
All sound like good points. re: linestyles, the current functionality is that you can plot several variables on the same plot and they will be differentiated by the linestyles, which is why the different solutions are only differentiated by colour. pybamm.QuickPlot(
solution,
output_variables=[
"Negative particle surface concentration",
"Positive particle surface concentration",
["Electrolyte current density", "Electrode current density"],
"Terminal voltage [V]",
],
) |
ah nice! I didn't know you could nest lists in that way to use in |
When we call ipywidgets within simulation for slider plots in jupyter notebook, I think we should also pass the argument |
Are you thinking to pass this in from the notebook or detect that it is being run from a notebook? |
Was thinking to just change line 536 of simulation to:
|
Regarding linestyles, that is really neat and I didn't know you could do that either. I still think it would be nice to do models by linestyle though (if multiple variables are not plotted on the same figure) since I would use this more frequently. |
can we just move |
One additional thing that would be nice, is if QuickPlot can accept solution objects and simulation objects. If a simulation object is passed, it just does simulation.solution automatically. I am finding myself writing [sim1.solution, sim2.solution, etc] or having to do [sim.solution for sim in [sim1, sim2, sim3]] quite a bit, which is just messy |
|
QuickPlot
could do with a few updates. Feel free to add more to this list:set_output_variables
to make it more obvious what is being doneSliderPlot
?The text was updated successfully, but these errors were encountered: