Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages #963

Closed
valentinsulzer opened this issue Apr 17, 2020 · 1 comment · Fixed by #971
Closed

Better error messages #963

valentinsulzer opened this issue Apr 17, 2020 · 1 comment · Fixed by #971
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

valentinsulzer commented Apr 17, 2020 •
edited
Loading

Some small changes / better error messages needed for increased usability:

  • Raise error when taking gradient of an object with no domain (but gradient of broadcast should work and return zero)
  • Raise error when trying to do boundary value of a gradient object
  • Allow re-processing discretised model Raise error when trying to re-process discretised model, and recommend using inplace=False
@valentinsulzer valentinsulzer self-assigned this Apr 17, 2020
valentinsulzer added a commit that referenced this issue Apr 19, 2020
@valentinsulzer
#963 start adding tests
3834a3e
valentinsulzer added a commit that referenced this issue Apr 19, 2020
@valentinsulzer
#963 add more tests
18895f1
valentinsulzer added a commit that referenced this issue Apr 19, 2020
@valentinsulzer
#963 fix unit tests
c4160bd
valentinsulzer added a commit that referenced this issue Apr 19, 2020
@valentinsulzer
#963 fix tests except finite volume
8b15020
@brosaplanella brosaplanella mentioned this issue Apr 20, 2020
Closed
@valentinsulzer
Copy link
Member Author

  • Check there are no Variable objects in the initial conditions

valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#963 fix tests
dc19206
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#963 make equations and bcs custom dictionaries, and add check for jac
c1642b8
valentinsulzer added a commit that referenced this issue Apr 24, 2020
@valentinsulzer
#963 make base submodel inherit from base model
ec54f71
@valentinsulzer valentinsulzer mentioned this issue Apr 28, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue Apr 28, 2020
@valentinsulzer
#963 changelog
5bd0762
valentinsulzer added a commit that referenced this issue Apr 28, 2020
@valentinsulzer
#963 merge #853
a819d9f
valentinsulzer added a commit that referenced this issue Apr 29, 2020
@valentinsulzer
#963 merge develop
b8de0c2
valentinsulzer added a commit that referenced this issue Apr 29, 2020
@valentinsulzer
#963 coverage
77d10da
valentinsulzer added a commit that referenced this issue Apr 29, 2020
@valentinsulzer
#963 make path absolute in test
1ace4ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 963 misc bugs pybamm-team/PyBaMM
1 participant
@valentinsulzer