Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resistance in Butler-Volmer #984

Closed
valentinsulzer opened this issue May 6, 2020 · 0 comments · Fixed by #994
Closed

Resistance in Butler-Volmer #984

valentinsulzer opened this issue May 6, 2020 · 0 comments · Fixed by #994
Assignees
@valentinsulzer

Comments

@valentinsulzer
Copy link
Member

Add option to formulate Butler-Volmer as

j = 2*j0*sinh(phi_s - phi_e - U - R*j)

Requires making j an algebraic state.
See #836
@valentinsulzer valentinsulzer self-assigned this May 11, 2020
@felipe-salinas felipe-salinas mentioned this issue May 13, 2020
Closed
valentinsulzer added a commit that referenced this issue May 13, 2020
@valentinsulzer
#984 add sei resistance to inverse BV
feb4d4f
valentinsulzer added a commit that referenced this issue May 13, 2020
@valentinsulzer
#984 reformat SEI to add film resistance and loss of lithium
4643732
valentinsulzer added a commit that referenced this issue May 13, 2020
@valentinsulzer
#984 add comments
1f74cdd
valentinsulzer added a commit that referenced this issue May 13, 2020
@valentinsulzer
#984 passing unit tests
28fc8f1
valentinsulzer added a commit that referenced this issue May 14, 2020
@valentinsulzer
#984 fix tests
09c9f95
@valentinsulzer valentinsulzer mentioned this issue May 14, 2020
Merged
8 tasks
valentinsulzer added a commit that referenced this issue May 14, 2020
@valentinsulzer
#984 coverage
c688816
valentinsulzer added a commit that referenced this issue May 14, 2020
@valentinsulzer
#984 fix scalings
5a55dbd
valentinsulzer added a commit that referenced this issue May 14, 2020
@valentinsulzer
#984 reformat interface docs
daf49ed
valentinsulzer added a commit that referenced this issue May 14, 2020
@valentinsulzer
#984 add unsaved file
e574b4f
valentinsulzer added a commit that referenced this issue May 14, 2020
@valentinsulzer
#984 fix models for output tests
aaa61dd
valentinsulzer added a commit that referenced this issue May 14, 2020
@valentinsulzer
#984 flake8 and test
7c2601b
valentinsulzer added a commit that referenced this issue May 15, 2020
@valentinsulzer
#984 use total current in sei film overpotential
3afb1e4
valentinsulzer added a commit that referenced this issue May 15, 2020
@valentinsulzer
#984 fix parameters
01d0452
valentinsulzer added a commit that referenced this issue May 15, 2020
@valentinsulzer
#984 fix parameter path??
4f44cd3
valentinsulzer added a commit that referenced this issue May 19, 2020
@valentinsulzer
#984 merge
62298fa
valentinsulzer added a commit that referenced this issue May 19, 2020
@valentinsulzer
#984 change sei nondimensionalization
3f1629c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinsulzer valentinsulzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 984 butler volmer resistance pybamm-team/PyBaMM
1 participant
@valentinsulzer