Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1037 fix timescale #1041

Merged
merged 3 commits into from
Jun 9, 2020
Merged

#1037 fix timescale #1041

merged 3 commits into from
Jun 9, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Jun 8, 2020

Fixes issue in notebooks where slider didn't update. Problem was the timescale in plot (the sliders update ok in notebook when the timescale is seconds). It worked in scripts as that called slider_update rather than plot

Fixes #1037

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #1041 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1041   +/-   ##
========================================
  Coverage    97.63%   97.63%           
========================================
  Files          237      237           
  Lines        12371    12371           
========================================
  Hits         12078    12078           
  Misses         293      293           
Impacted Files Coverage Δ
pybamm/plotting/quick_plot.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 814f5d9...c693933. Read the comment docs.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Rob! However, I tried it and I still have some lag (less than before) in the notebooks. I wonder if there is still something else going on.

@rtimms
Copy link
Contributor Author

rtimms commented Jun 8, 2020

it updates pretty quickly if you just click a point on the slider rather than slide. we use continuous_update=False, so it shouldn't update until you release the mouse, but it seems that it is...

@rtimms rtimms merged commit 672a512 into develop Jun 9, 2020
@rtimms rtimms deleted the issue-1037-slider-bug branch June 12, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slider plots in notebooks
3 participants