Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1413 plotting #1419

Merged
merged 13 commits into from
Mar 8, 2021
Merged

Issue 1413 plotting #1419

merged 13 commits into from
Mar 8, 2021

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Mar 5, 2021

Description

Introduces more customizability for QuickPlot and style, and an example for how to change the plotting style

Fixes #1413

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #1419 (36f9c09) into develop (e1c51a2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1419   +/-   ##
========================================
  Coverage    98.27%   98.27%           
========================================
  Files          278      279    +1     
  Lines        16109    16147   +38     
========================================
+ Hits         15831    15869   +38     
  Misses         278      278           
Impacted Files Coverage Δ
pybamm/plotting/plot.py 100.00% <ø> (ø)
pybamm/plotting/plot2D.py 100.00% <ø> (ø)
pybamm/__init__.py 94.95% <100.00%> (+0.17%) ⬆️
pybamm/plotting/plot_voltage_components.py 100.00% <100.00%> (ø)
pybamm/plotting/quick_plot.py 100.00% <100.00%> (ø)
pybamm/settings.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c51a2...36f9c09. Read the comment docs.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tino! Happy to merge once coverage passes.

@valentinsulzer valentinsulzer merged commit 4e18088 into develop Mar 8, 2021
@valentinsulzer valentinsulzer deleted the issue-1413-plotting branch March 8, 2021 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better plot styles
2 participants