-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1405 xaverage #1490
Issue 1405 xaverage #1490
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1490 +/- ##
========================================
Coverage 98.31% 98.32%
========================================
Files 295 294 -1
Lines 16783 16854 +71
========================================
+ Hits 16500 16571 +71
Misses 283 283
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat! thanks, @tinosulzer !
@@ -32,6 +32,7 @@ class DFN(BaseModel): | |||
|
|||
def __init__(self, options=None, name="Doyle-Fuller-Newman model", build=True): | |||
super().__init__(options, name) | |||
self.x_average = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be worth a comment here explaining why x_average
is True/False for different models (just in dfn, spm etc., not in every submodel)
return variables | ||
|
||
def set_rhs(self, variables): | ||
Domain = self.domain + " electrode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor style point, but odd for this to be capitalized. I guess to distinguish from self.domain
Description
Reformats the degradation models so that the x-averaged form can be used
Adds a reaction-driven LAM model from Reniers 2019
Fixes #1405
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: