Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1704 choose faster options for testing batch study #1762

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Oct 27, 2021

Description

Change the options in the batch study test to make it faster

Time reduction: 87s -> 26s

Fixes #1704

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1762 (67db4e0) into develop (f2c36a1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1762   +/-   ##
========================================
  Coverage    99.28%   99.28%           
========================================
  Files          343      343           
  Lines        18900    18900           
========================================
  Hits         18765    18765           
  Misses         135      135           
Impacted Files Coverage Δ
pybamm/models/standard_variables.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c36a1...67db4e0. Read the comment docs.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tinosulzer! Not related to the code - there is a typo in the linked issue number, merging this might close the wrong one

@valentinsulzer
Copy link
Member Author

thanks, fixed

@valentinsulzer valentinsulzer merged commit 79749cd into develop Oct 27, 2021
@valentinsulzer valentinsulzer deleted the issue-1704-test-batch-study branch October 27, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up batch study test
2 participants