Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release 21.11 #1834

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Prepare release 21.11 #1834

merged 2 commits into from
Nov 29, 2021

Conversation

brosaplanella
Copy link
Sponsor Member

@brosaplanella brosaplanella commented Nov 29, 2021

Description

Prepare develop for the new release 21.11. A few things left to do before merging:

  • Update vcpkg-configuration.json baseline (@priyanshuone6 can you point me to the right commit ID please?)
  • Update CHANGELOG: are there any of the open PRs we want to bring in before releasing @tinosulzer?
  • Jax: there is still the version issue (Update jax version #1625), is it OK to keep the versions as they are?

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1834 (4022d0f) into develop (0ab7c34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1834   +/-   ##
========================================
  Coverage    99.25%   99.25%           
========================================
  Files          340      340           
  Lines        18773    18773           
========================================
  Hits         18634    18634           
  Misses         139      139           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab7c34...4022d0f. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No urgent PRs to merge

@priyanshuone6
Copy link
Member

Tested the current commit ID of baseline and the workflow passed, don't think it needs to be updated
https://github.com/priyanshuone6/PyBaMM/runs/4355631546?check_suite_focus=true

@priyanshuone6
Copy link
Member

All the jax tests are passing with the current pinned versions I guess we can keep the jax versions as they are

@priyanshuone6
Copy link
Member

Updated the sdist action as Publish sdist on pypi step was getting skipped
https://github.com/pybamm-team/PyBaMM/runs/4094768383?check_suite_focus=true

@valentinsulzer valentinsulzer merged commit 051896e into develop Nov 29, 2021
@valentinsulzer valentinsulzer deleted the 21.11 branch November 29, 2021 19:19
@brosaplanella
Copy link
Sponsor Member Author

We need to reopen this one as I need to update the CHANGELOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants