-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jax cli #1881
Jax cli #1881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just some style comments
Codecov Report
@@ Coverage Diff @@
## develop #1881 +/- ##
===========================================
+ Coverage 99.28% 99.31% +0.03%
===========================================
Files 345 346 +1
Lines 19119 19105 -14
===========================================
- Hits 18983 18975 -8
+ Misses 136 130 -6
Continue to review full report at Codecov.
|
What are the lines that lost coverage? |
Not sure on why this is happening. Might be due to adding few init files? |
Looks like adding an |
Does there have to be an |
I don't think it is needed, as pybamm doesn't offer the |
Should I remove the init file from lithium_metal? |
Yes, thanks |
__init__
pybamm_install_jax