-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1903 power #1917
Issue 1903 power #1917
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1917 +/- ##
========================================
Coverage 99.32% 99.32%
========================================
Files 346 346
Lines 19002 19058 +56
========================================
+ Hits 18874 18930 +56
Misses 128 128
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tinosulzer looks good!
examples/scripts/DFN.py
Outdated
@@ -5,46 +5,41 @@ | |||
import pybamm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to change the example script back
"resistance", | ||
"differential resistance", | ||
"explicit resistance", | ||
"CCCV", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the CCCV option isn't listed in the docs
def get_coupled_variables(self, variables): | ||
param = self.param | ||
|
||
# Current is given as applied power divided by voltage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
voltage divided by resistance
Description
Adds more operating modes for power and resistance control.
The explicit models can only be used with DFN without surface form, so it's not possible to completely eliminate algebraic equations using that (but it can be done using the differential models)
Fixes #1903
Fixes #1691
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: