#2021 remove deprecation errors

[brosaplanella]

Description

Removed all the deprecation errors that I could find that were one year or older. Not sure what's the best way to automate removing deprecation errors in the future. Maybe we can just add a comment when we introduce one of the errors with the key work "deprecation" (or anything starting with deprec) and the date, so it is easy to search them and check how old they are.

Fixes #2021

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #2022 (00b8b0c) into develop (5643116) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2022      +/-   ##
===========================================
- Coverage    99.35%   99.35%   -0.01%     
===========================================
  Files          346      346              
  Lines        18972    18939      -33     
===========================================
- Hits         18849    18816      -33     
  Misses         123      123              

Impacted Files	Coverage Δ
pybamm/expression_tree/symbol.py	98.53% <ø> (-0.01%)	⬇️
pybamm/solvers/base_solver.py	100.00% <ø> (ø)
pybamm/solvers/idaklu_solver.py	97.69% <ø> (ø)
pybamm/solvers/scikits_dae_solver.py	98.63% <ø> (ø)
pybamm/solvers/scikits_ode_solver.py	89.28% <ø> (-0.25%)	⬇️
pybamm/util.py	100.00% <ø> (ø)
pybamm/parameters/parameter_values.py	99.43% <100.00%> (-0.03%)	⬇️
pybamm/simulation.py	98.24% <100.00%> (-0.01%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5643116...00b8b0c. Read the comment docs.

[priyanshuone6]

Looks good!

[valentinsulzer]

Thanks, looks good. We could start using https://pypi.org/project/deprecation/#description, which specifies by which version a warning should be removed and fails tests if not removed by then

[brosaplanella]

Thanks, looks good. We could start using https://pypi.org/project/deprecation/#description, which specifies by which version a warning should be removed and fails tests if not removed by then

Shall I replace some of the remaining deprecation errors using the package or should I merge the PR now?

[valentinsulzer]

Merge the PR and open an issue