Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2047 linux wheel #2058

Merged
merged 9 commits into from
May 13, 2022
Merged

I2047 linux wheel #2058

merged 9 commits into from
May 13, 2022

Conversation

martinjrobins
Copy link
Contributor

@martinjrobins martinjrobins commented May 12, 2022

Description

Fixes the mac and windows wheels which were not working correctly

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #2058 (46081dc) into develop (496672b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2058      +/-   ##
===========================================
- Coverage    99.36%   99.35%   -0.01%     
===========================================
  Files          346      346              
  Lines        19033    19033              
===========================================
- Hits         18912    18911       -1     
- Misses         121      122       +1     
Impacted Files Coverage Δ
pybamm/expression_tree/symbol.py 98.53% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496672b...46081dc. Read the comment docs.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Martin!

@martinjrobins martinjrobins merged commit 7fd5155 into develop May 13, 2022
@martinjrobins martinjrobins deleted the i2047-linux-wheel branch May 13, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants