Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up electrode SOH calculations #2199

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Conversation

valentinsulzer
Copy link
Member

@valentinsulzer valentinsulzer commented Jul 29, 2022

Description

Speed up some performance regressions introduced in #2192

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #2199 (4d40bb6) into develop (4c42312) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2199   +/-   ##
========================================
  Coverage    99.36%   99.36%           
========================================
  Files          355      355           
  Lines        19451    19506   +55     
========================================
+ Hits         19327    19382   +55     
  Misses         124      124           
Impacted Files Coverage Δ
...models/full_battery_models/lithium_ion/__init__.py 100.00% <ø> (ø)
...s/full_battery_models/lithium_ion/electrode_soh.py 100.00% <100.00%> (ø)
pybamm/simulation.py 98.83% <100.00%> (+0.01%) ⬆️
pybamm/solvers/solution.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c42312...4d40bb6. Read the comment docs.

@valentinsulzer
Copy link
Member Author

Would be good to merge this before the new release

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge once you have updated the CHANGELOG

@@ -864,7 +862,7 @@ def get_cycle_summary_variables(cycle_solution, esoh_sims):
}
)

# Voltage variables
# # Voltage variables
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# # Voltage variables
# Voltage variables

@valentinsulzer valentinsulzer merged commit ea467c6 into develop Jul 29, 2022
@valentinsulzer valentinsulzer deleted the faster-electrode-soh branch July 29, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants