Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1986 remove zero electrolyte concentration cut-off #2207

Merged
merged 10 commits into from
Aug 5, 2022

Conversation

valentinsulzer
Copy link
Member

Description

Removes the "Zero electrolyte concentration cut-off" event.
Adds some bounds to functions so that the solver still works even if we step into electrolyte depletion

Fixes #1986

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #2207 (36870f3) into develop (bb15440) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2207   +/-   ##
========================================
  Coverage    99.36%   99.36%           
========================================
  Files          355      355           
  Lines        19486    19499   +13     
========================================
+ Hits         19362    19375   +13     
  Misses         124      124           
Impacted Files Coverage Δ
...models/full_battery_models/lead_acid/basic_full.py 100.00% <ø> (ø)
...odels/full_battery_models/lithium_ion/basic_dfn.py 100.00% <ø> (ø)
..._battery_models/lithium_ion/basic_dfn_half_cell.py 99.01% <ø> (ø)
...lyte_conductivity/base_electrolyte_conductivity.py 98.68% <ø> (ø)
...dels/electrolyte_conductivity/full_conductivity.py 100.00% <ø> (ø)
...lectrolyte_diffusion/base_electrolyte_diffusion.py 100.00% <ø> (ø)
...ybamm/models/submodels/interface/base_interface.py 100.00% <ø> (ø)
...electrolyte_conductivity/composite_conductivity.py 100.00% <100.00%> (ø)
...lectrolyte_conductivity/integrated_conductivity.py 100.00% <100.00%> (ø)
...e_potential_form/full_surface_form_conductivity.py 100.00% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

pybamm/parameters/lithium_ion_parameters.py Outdated Show resolved Hide resolved
pybamm/parameters/lithium_ion_parameters.py Outdated Show resolved Hide resolved
@valentinsulzer valentinsulzer merged commit 96aaa75 into develop Aug 5, 2022
@valentinsulzer valentinsulzer deleted the issue-1986-electrolyte-cut-off branch September 15, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove zero-concentration cut-off event from DFN
2 participants