Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to entrypoint to pybamm_parameter_sets #2475

Merged
merged 3 commits into from
Nov 18, 2022

Conversation

awadell1
Copy link
Contributor

@awadell1 awadell1 commented Nov 18, 2022

Fixed a typo in docs on adding a new parameter set and added emphasis on installing/reinstalling the parameter set package.

Typo found via: #2452

Fix typo identified in pybamm-team#2452
Added emphasis on the need to install / reinstall the package
@awadell1
Copy link
Contributor Author

@tinosulzer Should be good to go

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (74bf311) compared to base (8bdc3e0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2475      +/-   ##
===========================================
- Coverage    99.72%   99.72%   -0.01%     
===========================================
  Files          258      257       -1     
  Lines        19264    18986     -278     
===========================================
- Hits         19211    18933     -278     
  Misses          53       53              
Impacted Files Coverage Δ
pybamm/parameters/parameter_sets.py 100.00% <100.00%> (ø)
pybamm/models/base_model.py 98.48% <0.00%> (-0.05%) ⬇️
pybamm/util.py 100.00% <0.00%> (ø)
pybamm/expression_tree/functions.py 100.00% <0.00%> (ø)
...ybamm/expression_tree/operations/evaluate_julia.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think parameter_sets should be plural, and the entry points code edited to allow that

@awadell1 awadell1 changed the title Fix typo in parameter sets docs Rename to entrypoint to pybamm_parameter_sets Nov 18, 2022
Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valentinsulzer valentinsulzer merged commit 8478e9a into pybamm-team:develop Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants