Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow differential surface form with MPM #2533

Merged
merged 6 commits into from
Dec 15, 2022
Merged

Allow differential surface form with MPM #2533

merged 6 commits into from
Dec 15, 2022

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Dec 7, 2022

Description

Allow the option "surface form": "differential" in MPM

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit and integration test for MPM with differential surface form

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 99.73% // Head: 99.73% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2c49aa3) compared to base (22e9d5a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2533      +/-   ##
===========================================
- Coverage    99.73%   99.73%   -0.01%     
===========================================
  Files          270      270              
  Lines        19373    19365       -8     
===========================================
- Hits         19321    19313       -8     
  Misses          52       52              
Impacted Files Coverage Δ
...bamm/models/full_battery_models/lithium_ion/mpm.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rtimms rtimms merged commit 1f25a1a into develop Dec 15, 2022
@rtimms rtimms deleted the mpm-surface-form branch December 15, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants